Skip to content

Commit

Permalink
ci: improve naming
Browse files Browse the repository at this point in the history
  • Loading branch information
wochinge committed Feb 29, 2024
1 parent 9302a75 commit 239d52d
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ jobs:
- "url:https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
trigger-catch-all:
name: Trigger-catch-all-check
name: Tests completed
# This job will be executed only after all the other tests
# are successful.
# This way we'll be able to mark only this test as required
Expand All @@ -352,3 +352,5 @@ jobs:
- integration-tests-macos
- integration-tests-windows
uses: deepset-ai/haystack/.github/workflows/tests_skipper_workflow.yml@ci/fix-catch-all2
with:
tests_were_skipped: false
4 changes: 3 additions & 1 deletion .github/workflows/tests_skipper_trigger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ jobs:
- test/test_requirements.txt
trigger-catch-all:
name: Trigger-catch-all-check
name: Tests completed
# Don't run this check if the PR contains both code and non-code changes (e.g. release notes)
needs: check_if_changed
if: needs.check_if_changed.outputs.code_changes == 'false'
uses: deepset-ai/haystack/.github/workflows/tests_skipper_workflow.yml@ci/fix-catch-all2
with:
tests_were_skipped: true
8 changes: 8 additions & 0 deletions .github/workflows/tests_skipper_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
name: Tests
on:
workflow_call:
inputs:
tests_were_skipped:
type: boolean
required: true

jobs:
catch-all:
Expand All @@ -13,4 +17,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Skip tests
if: ${{ github.event.inputs.tests_were_skipped }}
run: echo "Skipped!"
- name: Tests completed successfully
if: ${{ !github.event.inputs.tests_were_skipped }}
run: echo "Tests completed!"

0 comments on commit 239d52d

Please sign in to comment.