Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyPDFToDocument - remove deprecated converter init parameter #8586

Closed
anakin87 opened this issue Nov 26, 2024 · 1 comment · Fixed by #8609
Closed

PyPDFToDocument - remove deprecated converter init parameter #8586

anakin87 opened this issue Nov 26, 2024 · 1 comment · Fixed by #8609
Assignees
@mpangrazzi
Labels
P2 Medium priority, add to the next sprint if no P1 available
Milestone
2.9.0

Comments

@anakin87
Copy link
Member

anakin87 commented Nov 26, 2024 •
edited by mpangrazzi
Loading

This init parameter has been deprecated in #8569.

We should remove it before releasing Haystack 2.9.0.

(check #8553 for the motivation)
@anakin87 anakin87 added this to the 2.9.0 milestone Nov 26, 2024
@julian-risch julian-risch added the P2 Medium priority, add to the next sprint if no P1 available label Nov 30, 2024
@mpangrazzi mpangrazzi self-assigned this Dec 5, 2024
@mpangrazzi mpangrazzi mentioned this issue Dec 6, 2024
Merged
@mpangrazzi
Copy link
Contributor

Closing this since #8609 is merged now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpangrazzi mpangrazzi

Labels
P2 Medium priority, add to the next sprint if no P1 available
Projects
None yet
Milestone
2.9.0
Development

Successfully merging a pull request may close this issue.

refactor: remove deprecated 'converter' init parameter from PyPDFToDocument deepset-ai/haystack
3 participants
@mpangrazzi @julian-risch @anakin87