Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove deprecated 'converter' init parameter from PyPDFToDocument #8609

Merged
merged 1 commit into from
Dec 6, 2024
Merged

refactor: remove deprecated 'converter' init parameter from PyPDFToDocument #8609

merged 1 commit into from
Dec 6, 2024

Conversation

mpangrazzi
Copy link
Contributor

Related Issues

Proposed Changes:

  • I've removed the deprecated argument converter and PyPDFConverter from PyPDFToDocument. Updated unit/it tests accordingly.

How did you test it?

  • local unit and integration tests and CI

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@mpangrazzi mpangrazzi requested review from a team as code owners December 6, 2024 09:41
@mpangrazzi mpangrazzi requested review from dfokina and davidsbatista and removed request for a team December 6, 2024 09:41
@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Dec 6, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12196508255

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 90.333%
Files with Coverage Reduction New Missed Lines %
components/converters/pypdf.py 3 96.05%
Totals Coverage Status
Change from base Build 12196324030: 0.02%
Covered Lines: 8036
Relevant Lines: 8896
💛 - Coveralls

@davidsbatista davidsbatista changed the title remove deprecated 'converter' init parameter from PyPDFToDocument refactor: remove deprecated 'converter' init parameter from PyPDFToDocument Dec 6, 2024
@davidsbatista
Copy link
Contributor

@mpangrazzi i've just updated the PR title to refactor: remove deprecated 'converter' init parameter from PyPDFToDocument - I also often forgot :)

davidsbatista
davidsbatista approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpangrazzi mpangrazzi merged commit b32f85c into main Dec 6, 2024
19 checks passed
@mpangrazzi mpangrazzi deleted the remove-pypdf-converter branch December 6, 2024 14:43
@mpangrazzi mpangrazzi mentioned this pull request Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyPDFToDocument - remove deprecated converter init parameter
3 participants
@mpangrazzi @coveralls @davidsbatista