-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extend TransformersQueryClassifier
: clean version
#2965
feat: Extend TransformersQueryClassifier
: clean version
#2965
Conversation
It standardizes the way nodes can declare to have a variable number of outputs. Check out this method: haystack/haystack/nodes/base.py Line 131 in 91f954b
Right now you just declare 10 outgoing edges, as other nodes were doing, because there was no good way to tell the pipeline that your node could have a variable number of outputs. Now there is, so I recommend implementing that part in the new way. You can have a look at |
That would be fantastic! But maybe worth a separate PR. @TuanaCelik @mkkuemmel what do you think? |
Yes, I like the idea! A small section at the bottom of Tutorial 14. We just need to make sure it remains understandable (but good markdown formatting would go a long way already). I do agree that a separate PR would be good for this. |
…QueryClassifier_clean
…er_clean' into extend_TransformersQueryClassifier_clean
@ZanSara I've tried to implement the lightweight approach and move labels validation in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you once again 😊
There has been another PR targeting this node with the goal of adding progress bars to the run method. I'm afraid I can't help too much with the merge, but it doesn't seem too messy either. Feel free to tag @vblagoje (PR author) if something is unclear or you need help |
…QueryClassifier_clean
I hope to have correctly fixed the conflict now. @vblagoje 👋! |
TransformersQueryClassifier
: clean versionTransformersQueryClassifier
: clean version
Related Issue(s): fixes #2587
Proposed changes:
TransformersQueryClassifier
#2903TransformersQueryClassifier
supports text-classification and zero-shot-classificationPre-flight checklist
Two main doubts: