-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for gradient_checkpointing for Sentence Transformers training #5030
Conversation
Pull Request Test Coverage Report for Build 5256397223
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit puzzled by one bit of code specifically, let's talk about it before moving forward.
In addition, please next time open an issue before the PR, so we can have a discussion on the issue about the feature's design, and on the PR about the implementation details. I'm curious where the demand for this specific feature comes from 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more small thing to fix and this is ready to merge
retriever = EmbeddingRetriever( | ||
embedding_model="sentence-transformers/all-MiniLM-L6-v2", | ||
model_format="sentence_transformers", | ||
use_gpu=False, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really sorry I didn't notice it earlier 🙈 but is this initialization loading the model? If yes, can we mock the model as well so that we don't actually download and load the weights from hf?
If we can do that we'll be able to add the @pytest.mark.unit
marker to this test. Otherwise it won't run in CI.
As agreed with @sjrl we can close this for now and re-implement it in v2 later, if still relevant |
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.