-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PromptBuilder
#5713
Merged
Merged
Add PromptBuilder
#5713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
requested review from
dfokina and
ZanSara
and removed request for
a team
September 4, 2023 14:13
github-actions
bot
added
topic:tests
topic:dependencies
topic:build/distribution
type:documentation
Improvements on the docs
labels
Sep 4, 2023
silvanocerza
force-pushed
the
prompt-builder
branch
from
September 4, 2023 14:14
72b9a5c
to
0d13081
Compare
silvanocerza
force-pushed
the
prompt-builder
branch
from
September 4, 2023 14:26
0d13081
to
ee318e7
Compare
ZanSara
reviewed
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A couple of nitpicks, then I'll approve
ZanSara
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.x
Related to Haystack v2.0
topic:build/distribution
topic:dependencies
topic:tests
type:documentation
Improvements on the docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Add minimal
PromptBuilder
implementation to render string templates to prompt strings so they can be passed to Generator Components.Usage:
How did you test it?
Added unit tests.
Notes for the reviewer
I didn't add support for PromptHub as we still have no prompt templates using the new format.
Also it can be easily added in the future and I wanted to keep the PR small.
I already added
Jinja2
as a dependency inhaystack-ai
package.Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.