feat: Removed the unused "query" parameter from MetaFieldRanker #6293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the mandatory query parameter in the run method which was not used at all.
github-actions
bot
added
2.x
anakin87
added
the
ignore-for-release-notes
|
Hey. @sahusiddharth... Thanks for your first contribution! As you can see, some tests are failing: you should also change related tests in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the mandatory query parameter in the run method which was not used at all.
Related Issues
MetaFieldRanker2.0 #6292Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.