feat: implement support for structured logging #7126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
wochinge
commented
Feb 26, 2024
haystack/logging.py
Outdated
| # https://www.structlog.org/en/stable/standard-library.html#rendering-using-structlog-based-formatters-within-logging | ||
| # This means that we use structlog to format the log entries for entries emitted via `logging` and `structlog`. | ||
|
|
||
| shared_processors = [ |
There was a problem hiding this comment.
will add trace / log correlation in a separate PR
wochinge
commented
Feb 26, 2024
| haystack_logging.configure_logging() | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
| logger.warning("Hello, structured logging!", extra={"key1": "value1", "key2": "value2"}) |
There was a problem hiding this comment.
will add a new logger class to ease logging extras in a separate PR
wochinge
force-pushed
the
feat/structured-logging
branch
from
c5909b5 to
976f375
Compare
wochinge
requested review from
dfokina,
davidsbatista and
masci
and removed request for
a team
Pull Request Test Coverage Report for Build 8052623938Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 8050998893Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.