Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check tty / jupyter availability for logging config detection #7226

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Feb 27, 2024

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@wochinge wochinge requested review from a team as code owners February 27, 2024 15:27
@wochinge wochinge requested review from dfokina and silvanocerza and removed request for a team February 27, 2024 15:27
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 labels Feb 27, 2024
@wochinge wochinge changed the title feat: check tty availability for logging config detection feat: check tty / jupyter availability for logging config detection Feb 27, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8067647306

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 90.07%

Files with Coverage Reduction New Missed Lines %
logging.py 1 97.96%
Totals Coverage Status
Change from base Build 8066845210: 0.1%
Covered Lines: 5270
Relevant Lines: 5851

💛 - Coveralls

@wochinge wochinge merged commit 14f65d5 into main Feb 27, 2024
23 checks passed
@wochinge wochinge deleted the feat/haystack-logging-tty branch February 27, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants