-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: review and normalize haystack.components.websearch
#7236
Conversation
@@ -1,7 +1,7 @@ | |||
loaders: | |||
- type: haystack_pydoc_tools.loaders.CustomPythonLoader | |||
search_path: [../../../haystack/components/websearch] | |||
modules: ["serper_dev"] | |||
modules: ["serper_dev", "searchapi"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was missing 😱
@@ -174,7 +174,7 @@ def test_web_search(self): | |||
ws = SerperDevWebSearch(top_k=10) | |||
results = ws.run(query="Who is the boyfriend of Olivia Wilde?") | |||
documents = results["documents"] | |||
links = results["documents"] | |||
links = results["links"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test was wrong 🙈
title: Websearch
|
Pull Request Test Coverage Report for Build 8081642480Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, there's a couple of things to change.
Co-authored-by: Silvano Cerza <[email protected]>
This reverts commit 23d6f45.
Related Issues
haystack.components.websearch
#7118haystack.components.websearch
#7173Proposed Changes:
searchapi
to the indexed modulesHow did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.