-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HuggingFaceAPIDocumentEmbedder
#7485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
requested review from
dfokina and
shadeMe
and removed request for
a team
April 5, 2024 10:23
shadeMe
suggested changes
Apr 5, 2024
haystack/components/embedders/hugging_face_api_document_embedder.py
Outdated
Show resolved
Hide resolved
haystack/components/embedders/hugging_face_api_document_embedder.py
Outdated
Show resolved
Hide resolved
haystack/components/embedders/hugging_face_api_document_embedder.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Madeesh Kannan <[email protected]>
…tack into hfapidocembedder
shadeMe
approved these changes
Apr 5, 2024
Pull Request Test Coverage Report for Build 8600010381Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
HuggingFaceAPITextEmbedder
#7484 (please do not merge before the base has been merged)Proposed Changes:
HuggingFaceAPIDocumentEmbedder
HuggingFaceTEIDocumentEmbedder
How did you test it?
CI, new tests, extensive manual tests: with HF Inference API, local TEI container and paid HF Inference Endpoint
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.