Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix unit tests failing if HF_API_TOKEN is set #7491

Merged
merged 1 commit into from
Apr 5, 2024
Merged

CI: Fix unit tests failing if HF_API_TOKEN is set #7491

merged 1 commit into from
Apr 5, 2024

Conversation

silvanocerza
Copy link
Contributor

This should fix failures in main caused by #7490.

@silvanocerza silvanocerza added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Apr 5, 2024
@silvanocerza silvanocerza self-assigned this Apr 5, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner April 5, 2024 15:40
@silvanocerza silvanocerza requested review from julian-risch and removed request for a team April 5, 2024 15:40
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 labels Apr 5, 2024
@silvanocerza silvanocerza requested review from anakin87 and removed request for julian-risch April 5, 2024 15:41
anakin87
anakin87 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope so.
Thanks!

@silvanocerza silvanocerza merged commit ff269db into main Apr 5, 2024
21 checks passed
@silvanocerza silvanocerza deleted the fix-hf-unit-tests branch April 5, 2024 16:05
@anakin87 anakin87 mentioned this pull request Apr 5, 2024
Closed
@silvanocerza silvanocerza added this to the 2.0.1 milestone Apr 8, 2024
silvanocerza added a commit that referenced this pull request Apr 8, 2024
@silvanocerza
Fix unit tests failing if HF_API_TOKEN is set (#7491)
3c4e200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees

@silvanocerza silvanocerza

Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @anakin87