Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for returning intermediate outputs of pipeline components #7504

Merged
merged 6 commits into from
Apr 10, 2024
Merged

feat: Add support for returning intermediate outputs of pipeline components #7504

merged 6 commits into from
Apr 10, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Apr 8, 2024

Proposed Changes:

The pipeline.run method has been extended to accept a set of component names whose inputs are returned in addition to the outputs of leaf components.

This is a prerequisite for the upcoming evaluation harness code.

How did you test it?

Unit tests.

Checklist

shadeMe added 2 commits April 8, 2024 17:39
@shadeMe
feat: Add support for returning intermediate outputs of pipeline comp…
86cce23 
…onents

The `pipeline.run` method has been extended to accept a set of component
names whose inputs are returned in addition to the outputs of leaf components.
@shadeMe
Add reno
0c1d25c
@shadeMe shadeMe added topic:pipeline 2.x Related to Haystack v2.0 labels Apr 8, 2024
@shadeMe shadeMe added this to the 2.1.0 milestone Apr 8, 2024
@shadeMe shadeMe requested review from masci and silvanocerza April 8, 2024 15:50
@github-actions github-actions bot added the type:documentation Improvements on the docs label Apr 8, 2024
@coveralls
Copy link
Collaborator

coveralls commented Apr 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8616489006

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 89.828%
Files with Coverage Reduction New Missed Lines %
core/pipeline/pipeline.py 8 93.97%
Totals Coverage Status
Change from base Build 8615952921: 0.01%
Covered Lines: 6173
Relevant Lines: 6872
💛 - Coveralls

@shadeMe
Copy link
Contributor Author

shadeMe commented Apr 9, 2024

Integration test failures appear to be unrelated.

@shadeMe shadeMe marked this pull request as ready for review April 9, 2024 09:37
@shadeMe shadeMe requested review from a team as code owners April 9, 2024 09:37
@shadeMe shadeMe requested review from dfokina and davidsbatista and removed request for a team and davidsbatista April 9, 2024 09:37
silvanocerza
silvanocerza approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@shadeMe shadeMe merged commit fd84cd5 into deepset-ai:main Apr 10, 2024
23 checks passed
@shadeMe shadeMe deleted the feat/pipeline-intermediate-results branch April 10, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@masci masci Awaiting requested review from masci

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:core topic:pipeline topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shadeMe @coveralls @silvanocerza @anakin87