fix: Fix corner case when running Pipeline that causes it to get stuck in a loop #7531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
With PR #7434 we introduced this bug that would cause a Pipeline to get stuck in an infinite loop when running if the following conditions are met:
This PR fixes this bug by making sure that a Component with defaults has all the necessary inputs to run when adding it in the
to_run
list when we notice we're stuck in a loop with Components that can still run.How did you test it?
I added a unit test to reproduce the issue.
Notes for the reviewer
This bug has been discovered after this message on Discord.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.