feat: support for bedrock mistral models and claude messages api #7543
Conversation
| @@ -27,7 +27,7 @@ repos: | |||
| - id: ruff | |||
|
|
|||
| - repo: https://github.com/codespell-project/codespell | |||
| rev: v2.2.5 | |||
| rev: b8ecc9b3acf31690c3cb2fc5bb03a3fbbbc2d7a3 | |||
There was a problem hiding this comment.
Version supporting inline ignores has been merged but not released yet.
There was a problem hiding this comment.
Do you super badly need this? Let's not "pollute" this PR with such details, wdyt?
There was a problem hiding this comment.
@vblagoje if we don't bump that, we can't use inline ignores such as the one in line 262 of haystack/nodes/prompt/invocation_layer/amazon_bedrock.py. So we would need to globally ignore "tral" for spell corrections which is worse than just bumping codespell from my view.
|
@vblagoje would also be nice to have in next release |
|
@tstadel will review and include 🙏 |
| @@ -27,7 +27,7 @@ repos: | |||
| - id: ruff | |||
|
|
|||
| - repo: https://github.com/codespell-project/codespell | |||
| rev: v2.2.5 | |||
| rev: b8ecc9b3acf31690c3cb2fc5bb03a3fbbbc2d7a3 | |||
There was a problem hiding this comment.
Do you super badly need this? Let's not "pollute" this PR with such details, wdyt?
|
@tstadel can we merge this ? |
|
@vblagoje if you're ok with my comment under #7543 (comment) feel free to merge. |
|
Ok let's merge this one @tstadel @ArzelaAscoIi |
tstadel
deleted the
feat/bedrock_mistral_and_claude_messages_api_support
branch
* feat: support for bedrock mistral models and claude messages api * feat: support for bedrock mistral models and claude messages api * fix mypy
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
use_messages_api: False.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.