feat: add default template to DynamicPromptBuilder #7652
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Currently we cannot have both:
There are two options:
DynamicPromptBuilder
and leavePromptBuilder
as isPromptBuilder
and deprecateDynamicPromptBuilder
This is Option A
See #7655 for Option B
Proposed Changes:
This extends DynamicPromptBuilder to have a default prompt template that is specified at init time.
How did you test it?
Notes for the reviewer
prompt_source
param has been renamed totemplate
for consistency. We can undo that if necessary.PromptBuilder
only has a subset ofDynamicPromptBuilder
's and no additional functionality, I would prefer Option BChat
counterpart toDynamicPromptBuilder
would still need to be implementedChecklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.