You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. 1 out of 2 committers have signed the CLA.
✅ davidsbatista ❌ GalRabin You have signed the CLA already but the status is still pending? Let us recheck it.
Very nice @GalRabin , thank you for this contribution. Normally we require unit tests for contribution (if applicable) but in this case we'll be adding a suite of tests just for component in the pipelines (de)serialization. Perhaps in this case we can make an exception as these tests are going to get added soon. cc @anakin87@davidsbatista
@GalRabin there seem to be some minor failures, related to import order in the files changed. Please have a look, should be a simple fix to satisfy this validator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
The wrapped doesn't triggered on inheritance therefor it doesn't added to the registry, therefor I added it as well to the super class as well
How did you test it?
manual verification on my code
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.