Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log line with reserved name keyword #7696

Closed

Conversation

ArzelaAscoIi
Copy link
Member

Related Issues

  • fixes Attempt to overwrite 'name' in LogRecord\

Proposed Changes:

  • drop duplicate code line

How did you test it?

  • not really (a test that the logger is not called with reserved names would be nice)

Notes for the reviewer

Its a bit surprising that this is not yet raised by the CI 🤔 (Will need to check the logging config)

Checklist

@ArzelaAscoIi ArzelaAscoIi requested a review from a team as a code owner May 14, 2024 08:41
@ArzelaAscoIi ArzelaAscoIi requested review from anakin87 and removed request for a team May 14, 2024 08:41
@github-actions github-actions bot added topic:core type:documentation Improvements on the docs labels May 14, 2024
@anakin87
Copy link
Member

Hello!

I think this has been fixed in #7679.

@ArzelaAscoIi ArzelaAscoIi deleted the fix/logLineWithNameCall branch May 14, 2024 08:45
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9076388839

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.408%

Totals Coverage Status
Change from base Build 9074873557: 0.0%
Covered Lines: 6532
Relevant Lines: 7225

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:core type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants