feat: change HTML conversion backend from boilerpy3 to Trafilatura #7705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
requested review from
dfokina and
julian-risch
and removed request for
a team
github-actions
bot
added
topic:tests
topic:build/distribution
type:documentation
anakin87
requested review from
masci and
vblagoje
and removed request for
julian-risch
anakin87
commented
May 16, 2024
| @@ -57,7 +57,7 @@ dependencies = [ | |||
| "more-itertools", # TextDocumentSplitter | |||
| "networkx", # Pipeline graphs | |||
| "typing_extensions>=4.7", # typing support for Python 3.8 | |||
| "boilerpy3", # Fulltext extraction from HTML pages | |||
| "trafilatura", # Fulltext extraction from HTML pages | |||
There was a problem hiding this comment.
This is my main concern.
boilerpy3 is 163kb, while trafilatura is 1390kb.
If you think it's better, I can add trafilatura as an optional dependency and wrap it in a lazy import block.
There was a problem hiding this comment.
1.4Mb is still ok, let's keep it
Pull Request Test Coverage Report for Build 9116483899Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
vblagoje
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
As discussed offline, we want to replace boilerpy3 with Trafilatura, which is robust and well-maintained.
During my recent work on AutoQuizzer, I battle-tested this library, which worked well for a diverse range of HTML pages.
I'm trying not to break the existing API. The implementation is simpler.
How did you test it?
CI, new tests.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.