Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Extend YAML serialization to allow Python tuples #7853

Merged
merged 1 commit into from
Jun 14, 2024
Merged

feat: Extend YAML serialization to allow Python tuples #7853

merged 1 commit into from
Jun 14, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Jun 13, 2024

Related Issues

Proposed Changes:

Currently, serialization to YAML does not support Python tuples. This PR extends support to them on the marshaller level, allowing all components and integrations to take advantage of it.

How did you test it?

All tests

Checklist

@shadeMe shadeMe added 2.x Related to Haystack v2.0 topic:core labels Jun 13, 2024
@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Jun 13, 2024
@shadeMe shadeMe force-pushed the feat/serialization-handle-tuples branch from 5a1c8af to 9a29b91 Compare June 13, 2024 13:34
@coveralls
Copy link
Collaborator

coveralls commented Jun 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9500671435

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 89.645%
Totals Coverage Status
Change from base Build 9497203825: 0.005%
Covered Lines: 6900
Relevant Lines: 7697
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9500650842

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 89.645%
Totals Coverage Status
Change from base Build 9497203825: 0.005%
Covered Lines: 6900
Relevant Lines: 7697
💛 - Coveralls

@shadeMe shadeMe force-pushed the feat/serialization-handle-tuples branch from 9a29b91 to 95ec5dd Compare June 13, 2024 13:45
@shadeMe shadeMe marked this pull request as ready for review June 13, 2024 13:45
@shadeMe shadeMe requested review from a team as code owners June 13, 2024 13:45
@shadeMe shadeMe requested review from dfokina, masci and silvanocerza and removed request for a team June 13, 2024 13:45
@coveralls
Copy link
Collaborator

coveralls commented Jun 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9500835226

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 89.645%
Totals Coverage Status
Change from base Build 9497203825: 0.005%
Covered Lines: 6900
Relevant Lines: 7697
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9500836597

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 89.645%
Totals Coverage Status
Change from base Build 9497203825: 0.005%
Covered Lines: 6900
Relevant Lines: 7697
💛 - Coveralls

@shadeMe shadeMe merged commit 2f6ae41 into deepset-ai:main Jun 14, 2024
34 checks passed
@shadeMe shadeMe deleted the feat/serialization-handle-tuples branch June 14, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

@masci masci Awaiting requested review from masci masci is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:core topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when serializing ElasticSearchEmbeddingRetriever from ElasticSearchDocumentStore with authentication
3 participants
@shadeMe @coveralls @silvanocerza