Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix PredefinedPipeline.CHAT_WITH_WEBSITE template #8401

Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix: fix PredefinedPipeline.CHAT_WITH_WEBSITE template #8401

merged 3 commits into from
Sep 25, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

Update the CHAT_WITH_WEBSITE Pipeline template to reflect the changes in the HTMLToDocument converter component.

How did you test it?

Manual tests.

Checklist

@anakin87 anakin87 requested review from a team as code owners September 24, 2024 16:23
@anakin87 anakin87 requested review from dfokina, davidsbatista and silvanocerza and removed request for a team and davidsbatista September 24, 2024 16:23
@coveralls
Copy link
Collaborator

coveralls commented Sep 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11018271100

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.358%
Totals Coverage Status
Change from base Build 11015717691: 0.0%
Covered Lines: 7338
Relevant Lines: 8121
💛 - Coveralls

@anakin87 anakin87 merged commit 2cc76be into main Sep 25, 2024
15 checks passed
@anakin87 anakin87 deleted the fix-pipe-template branch September 25, 2024 08:06
@anakin87 anakin87 mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajit97singh ajit97singh ajit97singh approved these changes

@davidsbatista davidsbatista davidsbatista approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

@silvanocerza silvanocerza Awaiting requested review from silvanocerza

Assignees
No one assigned
Labels
topic:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PredefinedPipeline.CHAT_WITH_WEBSITE fails deserialization
4 participants
@anakin87 @coveralls @davidsbatista @ajit97singh