-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add XLSXToDocument converter #8522
Conversation
Hey @bglearning I'd like to discuss with you how got references to work (e.g. pointing to the correct row in the original Excel table) to make sure we accommodate that properly in this component. |
Pull Request Test Coverage Report for Build 12685532464Details
💛 - Coveralls |
btw @sjrl , looks like
So the out_header (or equivalent) can be made the same for both (List[str]) which would just be the columns by default (if excel_column_names is optional). Also on the flip side,
|
Just realized I'd like to do a bit more testing. Especially what happens when a complicated table is converted such as what happens if cells are merged, etc. So a TODO
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some initial comments.
Overall, the PR looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Feel free to add a test with a realistic table (#8522 (comment)), then it's ready to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to ship this feature in the next release,
so we can skip the test with a realistic table for the moment.
It would be great if we can add it later.
Related Issues
Proposed Changes:
Draft of the Excel to Document converter
How did you test it?
Added tests
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.