-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docstring for normalization #8604
fix: docstring for normalization #8604
Conversation
Pull Request Test Coverage Report for Build 12201934960Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
releasenotes/notes/fix-docstrings-normalize-embedding-fd2dba50ba9e51a1.yaml
Show resolved
Hide resolved
haystack/components/embedders/sentence_transformers_document_embedder.py
Outdated
Show resolved
Hide resolved
haystack/components/embedders/sentence_transformers_text_embedder.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left a few minor suggestions.
@ArzelaAscoIi can you also add the |
Related Issues
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
and added!
in case the PR includes breaking changes.