Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docstring for normalization #8604

Merged

Conversation

ArzelaAscoIi
Copy link
Member

Related Issues

  • wrong docstring

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@ArzelaAscoIi ArzelaAscoIi requested a review from a team as a code owner December 4, 2024 13:12
@ArzelaAscoIi ArzelaAscoIi requested review from anakin87 and removed request for a team December 4, 2024 13:12
@github-actions github-actions bot added the type:documentation Improvements on the docs label Dec 4, 2024
@ArzelaAscoIi ArzelaAscoIi requested a review from a team as a code owner December 4, 2024 13:15
@ArzelaAscoIi ArzelaAscoIi requested review from dfokina and removed request for a team December 4, 2024 13:15
@coveralls
Copy link
Collaborator

coveralls commented Dec 4, 2024

Pull Request Test Coverage Report for Build 12201934960

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 90.333%

Files with Coverage Reduction New Missed Lines %
components/converters/pypdf.py 3 96.05%
Totals Coverage Status
Change from base Build 12157066045: 0.02%
Covered Lines: 8036
Relevant Lines: 8896

💛 - Coveralls

Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a few minor suggestions.

@davidsbatista
Copy link
Contributor

davidsbatista commented Dec 4, 2024

@ArzelaAscoIi can you also add the # pylint: disable=too-many-positional-arguments to the init of each class? since this files were changed the linter while checked them and apply the new rules

@davidsbatista davidsbatista merged commit ed2f37d into deepset-ai:main Dec 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants