Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: converting some DocumentJoiner methods to staticmethod #8606

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Dec 5, 2024

Proposed Changes:

_concatenate() and _distribution_based_rank_fusion() should be static methods

How did you test it?

  • local unit tests
  • CI tests

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@coveralls
Copy link
Collaborator

coveralls commented Dec 5, 2024

Pull Request Test Coverage Report for Build 12181526861

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 90.318%

Totals Coverage Status
Change from base Build 12163495558: 0.003%
Covered Lines: 8050
Relevant Lines: 8913

💛 - Coveralls

@github-actions github-actions bot added the type:documentation Improvements on the docs label Dec 5, 2024
@davidsbatista davidsbatista changed the title chore: converting some DocumentJoiner methods to staticmethod refactor: converting some DocumentJoiner methods to staticmethod Dec 5, 2024
@davidsbatista davidsbatista marked this pull request as ready for review December 5, 2024 14:14
@davidsbatista davidsbatista requested review from a team as code owners December 5, 2024 14:14
@davidsbatista davidsbatista requested review from dfokina, Amnah199 and julian-risch and removed request for a team December 5, 2024 14:14
@davidsbatista davidsbatista removed the type:documentation Improvements on the docs label Dec 5, 2024
Copy link
Contributor

@Amnah199 Amnah199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@davidsbatista davidsbatista merged commit 3da5bac into main Dec 6, 2024
35 checks passed
@davidsbatista davidsbatista deleted the convert-some-docjoiner-methods-to-static branch December 6, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants