Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: end2end tests due to behaviour of DocumentSplitter "sentence" being replaced by "period" #8635

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix: end2end tests due to behaviour of DocumentSplitter "sentence" being replaced by "period" #8635

merged 1 commit into from
Dec 13, 2024

Conversation

davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Dec 13, 2024 •
edited
Loading

How did you test it?

  • local end2endtests + CI tests

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Dec 13, 2024
@davidsbatista davidsbatista changed the title initial import fix: end2end tests due to behaviour of DocumentSplitter "sentence" being replaced by "period" Dec 13, 2024
@davidsbatista davidsbatista marked this pull request as ready for review December 13, 2024 09:48
@davidsbatista davidsbatista requested a review from a team as a code owner December 13, 2024 09:48
@davidsbatista davidsbatista requested review from mpangrazzi and anakin87 and removed request for a team December 13, 2024 09:48
@davidsbatista davidsbatista merged commit 176db5d into main Dec 13, 2024
13 of 14 checks passed
@davidsbatista davidsbatista deleted the fixing-tests-new-sentence-behaviour branch December 13, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

@mpangrazzi mpangrazzi Awaiting requested review from mpangrazzi mpangrazzi is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidsbatista @anakin87