Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update component registration to use new class reference #8715

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kaqmak
Copy link

@kaqmak kaqmak commented Jan 13, 2025

The pyright language server is now able to resolve the import and provide completions for the component.

Related Issues

Proposed Changes:

Reuse of the name of the newly created class caused a type error and the type checker did not recognize the parameters. Renaming the newly created class to new_class seems to fix the problem.

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

The pyright language server is now able to resolve the import and provide completions for the component.
@kaqmak kaqmak requested a review from a team as a code owner January 13, 2025 14:27
@kaqmak kaqmak requested review from mpangrazzi and removed request for a team January 13, 2025 14:27
@CLAassistant
Copy link

CLAassistant commented Jan 13, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyright type check breaks with version 2.8.0
2 participants