Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removing NLTKDocumentSplitter #8723

Closed
wants to merge 2 commits into from
Closed

chore: removing NLTKDocumentSplitter #8723

wants to merge 2 commits into from

Conversation

davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Jan 15, 2025 •
edited
Loading

Related Issues

Proposed Changes:

  • Removing deprecated NLTKDocumentSplitter

How did you test it?

  • local unit tests + CI tests

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic:core topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove NLTKDocumentSplitter
1 participant
@davidsbatista