Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AsyncPipeline logging name can't be overwritten #8845

Merged
merged 5 commits into from
Feb 12, 2025
Merged

fix: AsyncPipeline logging name can't be overwritten #8845

merged 5 commits into from
Feb 12, 2025

Conversation

mathislucka
Copy link
Member

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@mathislucka mathislucka requested a review from a team as a code owner February 12, 2025 10:20
@mathislucka mathislucka requested review from Amnah199 and removed request for a team February 12, 2025 10:20
@mathislucka
Copy link
Member Author

Also see this for reference: #7545 (comment)

@mathislucka mathislucka added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Feb 12, 2025
@github-actions github-actions bot added the type:documentation Improvements on the docs label Feb 12, 2025
@julian-risch julian-risch added this to the 2.10.0 milestone Feb 12, 2025
Amnah199
Amnah199 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@Amnah199 Amnah199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@anakin87 anakin87 enabled auto-merge (squash) February 12, 2025 11:05
@anakin87 anakin87 merged commit 88ed301 into main Feb 12, 2025
15 checks passed
@anakin87 anakin87 deleted the fix/pipeline_logging branch February 12, 2025 11:21
anakin87 pushed a commit that referenced this pull request Feb 12, 2025
@mathislucka @Amnah199 @anakin87
fix: AsyncPipeline logging name can't be overwritten (#8845)
00f41a5 
* fix: component_name not name in logging statement

* fix: component_name not name in logging statement

* fix: don't use fstrings in logging

---------

Co-authored-by: Amna Mubashar <[email protected]>
@coveralls
Copy link
Collaborator

coveralls commented Feb 13, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13283255310

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 47 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 91.45%
Files with Coverage Reduction New Missed Lines %
core/pipeline/async_pipeline.py 47 64.08%
Totals Coverage Status
Change from base Build 13263397194: 0.0%
Covered Lines: 9412
Relevant Lines: 10292
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amnah199 Amnah199 Amnah199 approved these changes

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:core type:documentation Improvements on the docs
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

KeyError: "Attempt to overwrite 'name' in LogRecord" in async_pipeline.py
5 participants
@mathislucka @coveralls @Amnah199 @julian-risch @anakin87