feat: add alby support to send bulk #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topether21
force-pushed
the
ruben/ENG-380/allow-users-to-perform-bulk-transfers-if-they-have-a-cardinal-utxo
branch
3 times, most recently
from
86b40ee to
1395328
Compare
topether21
force-pushed
the
ruben/ENG-380/allow-users-to-perform-bulk-transfers-if-they-have-a-cardinal-utxo
branch
from
0e58fa3 to
eb89e35
Compare
topether21
changed the title
topether21
force-pushed
the
ruben/ENG-380/allow-users-to-perform-bulk-transfers-if-they-have-a-cardinal-utxo
branch
2 times, most recently
from
a711010 to
e1fd335
Compare
habibitcoin
requested changes
May 15, 2024
| .filter((x) => x.status.confirmed) | ||
| .filter((x) => x.value > 10000) | ||
| .filter(utxo => !utxo.inscriptionId) | ||
| .sort((a, b) => b.value - a.value); |
There was a problem hiding this comment.
nit: maybe actually better to do smallest to largest
There was a problem hiding this comment.
ignore this, nevermind. You are trying to use the largest spendable UTXO as a cardinal if you need to add one
There was a problem hiding this comment.
we should select and use the largest first
There was a problem hiding this comment.
Yeah, it uses the biggest first.
topether21
force-pushed
the
ruben/ENG-380/allow-users-to-perform-bulk-transfers-if-they-have-a-cardinal-utxo
branch
from
e1fd335 to
f5f3f14
Compare
topether21
force-pushed
the
ruben/ENG-380/allow-users-to-perform-bulk-transfers-if-they-have-a-cardinal-utxo
branch
from
78f8255 to
5d32717
Compare
habibitcoin
approved these changes
May 17, 2024
| @@ -331,6 +338,183 @@ const Psbt = function (config) { | |||
| return psbtModule.broadcastPsbt(psbt); | |||
| }, | |||
|
|
|||
| preparePsbtForMultipleSend: async ({ | |||
There was a problem hiding this comment.
nit: maybe add comment to describe general flow:
preparePsbtForMultipleSend allows safe bulk UTXO transfers, with appropriate fees.
1. Any input UTXOs with an inscription will be created as a distinct output UTXO of the same size, and appear before any non-inscription UTXOs in the resultant PSBT
2. Any input UTXOs without an inscription will have their amounts consolidated into a single output UTXO
3. A check is run to ensure that enough cardinal funds are available to perform the transfer. If step 2 does not contain enough cardinal funds, cardinal funds will be appended to the PSBT, and another change output will be created
| throw new Error('Signing not supported.'); | ||
| } | ||
|
|
||
| const cardinalUtxos = ownedUtxos.filter(utxo => !selectedUtxos.some(ownedUtxo => ownedUtxo.txid === utxo.txid)) |
There was a problem hiding this comment.
nit: maybe add comment
// only used if selectedCardinalAmount is not large enough to cover fees
| } | ||
| inputs.push(utxo); | ||
| totalCardinalAmount += utxo.value; | ||
| isCardinalAdded = true; |
| address, | ||
| value: changeAmount, | ||
| }); | ||
| metadata.outputs.push({ type: 'Change' }); |
topether21
force-pushed
the
ruben/ENG-380/allow-users-to-perform-bulk-transfers-if-they-have-a-cardinal-utxo
branch
from
a6a1347 to
463167e
Compare
habibitcoin
deleted the
ruben/ENG-380/allow-users-to-perform-bulk-transfers-if-they-have-a-cardinal-utxo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.