Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add toolbox egress #77

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix: add toolbox egress #77

merged 2 commits into from
Mar 20, 2024

Conversation

blancharda
Copy link
Contributor

Description

Enable toolbox egress for rake tasks and other debugging.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Racer159
Racer159 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable addition

@zachariahmiller zachariahmiller self-requested a review March 20, 2024 01:23
zachariahmiller
zachariahmiller approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@zachariahmiller zachariahmiller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Just a note per the discussion in this PR the netpol generation will get updated soon to default to less open but with the ability to override from the config chart values as needed, ideally to more specific targets than remote: Anywhere. We'll communicate this change but it would break existing deployments. Will try to tackle this asap so impact is minimal. @blancharda

@zachariahmiller zachariahmiller changed the title feat: toolbox egress fix: add toolbox egress Mar 20, 2024
@zachariahmiller zachariahmiller mentioned this pull request Mar 20, 2024
Closed
@zachariahmiller
Copy link
Contributor

Sounds good. Just a note per the discussion in this PR the netpol generation will get updated soon to default to less open but with the ability to override from the config chart values as needed, ideally to more specific targets than remote: Anywhere. We'll communicate this change but it would break existing deployments. Will try to tackle this asap so impact is minimal. @blancharda

For reference this is the follow up issue #78

@zachariahmiller zachariahmiller merged commit 340f3f2 into main Mar 20, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Merged
@blancharda blancharda mentioned this pull request Mar 20, 2024
Closed
@blancharda
Copy link
Contributor Author

Lol. My convo hadn't refreshed and I missed your comment with the issue ref.
We can combine/close #82 as a duplicate.

@blancharda blancharda deleted the feature/toolbox-egress branch March 20, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachariahmiller zachariahmiller zachariahmiller approved these changes

@Racer159 Racer159 Racer159 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blancharda @zachariahmiller @Racer159