chore: refactor image publishing to new AWS ORG #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelmccoy
commented
Feb 20, 2025
| @@ -1,15 +1,3 @@ | |||
| variable "vpc_name" { | |||
There was a problem hiding this comment.
note: removing these in favor of just using the default vpc in the uds-images accounts
| state_bucket="uds-ci-govcloud-us-gov-west-1-tfstate" | ||
| vpc_name="uds-ci-govcloud-*" | ||
| subnet_name="uds-ci-govcloud-*-public*" | ||
| state_bucket="uds-tf-state-20250206161918002400000003" |
There was a problem hiding this comment.
note: this is the new state bucket in the govcloud uds-images account
| state_bucket="uds-aws-ci-commercial-us-west-2-5246-tfstate" | ||
| vpc_name="uds-ci-commercial-*" | ||
| subnet_name="uds-ci-commercial-*-public*" | ||
| state_bucket="uds-tf-state-20250206161747757600000003" |
There was a problem hiding this comment.
note: this is the state bucket in the new commercial uds-images account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #96
This PR attempts to refactor the image publishing for this repo to do a couple things:
Before I can kick off the e2e test with the infra, the following github secrets will need to be populated (i can handle this once things look good):
AWS_COMMERCIAL_ORG_ROLE_TO_ASSUME-> needs to be updated to the OIDC role in the uds-images commercial accountAWS_GOVCLOUD_ORG_ROLE_TO_ASSUME-> needs to be updated to the OIDC role in the uds-images govcloud accountAWS_OLD_COMMERCIAL_CI_ACCOUNT_ID-> needs to set to the old commercial ci AWS account id (for sharing)AWS_OLD_GOVCLOUD_CI_ACCOUNT_ID-> needs to set to the old govcloud ci AWS account id (for sharing)AWS_COMMERCIAL_ORG_ARN-> needs to be set to the new AWS Commercial Org ARN for sharing across the whole orgAWS_GOVCLOUD_ORG_ARN-> needs to be set to the new AWS Govcloud Org ARN for sharing across the whole orgIf all looks good, I will populate these secrets and kick off an e2e test and rerun the build workflows on this PR.