Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update token-metadata for Mushrooms Finance token #122

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mushroomsforest
Copy link

No description provided.

@mushroomsforest
Copy link
Author

mushroomsforest commented Dec 23, 2020

@pxr13 @nadavhollander Hey dharma team, would you please shed a light how to correct the logo png file? it seems aligned with your requirement as below, Really appreciate

metadata.json › 0x25e1474170c4c0aA64fa98123bdc8dB49D7802fa › logo.png › should have valid dimensions

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

       98 |                         it("should have valid dimensions", () => {
       99 |                             const validDimension = isValidDimension(logoPath);
    > 100 |                             expect(validDimension).toBe(true);
          |                                                    ^
      101 |                         });
      102 | 
      103 |                         it("should have a valid size", () => {

      at Object.it (test/token-metadata/metadata.test.js:100:52)
- Dimension: 256 x 256 pixels or 512 x 512 pixels.
- Background: preferably transparent (should fit dark mode as well; deny logos need light border/background).
- File size: maximum 100kB.

image

@d1ll0n
Copy link
Contributor

d1ll0n commented Jan 4, 2021

Hello @mushroomsforest - you can fix the failing CI tests by merging master into your branch.

@mushroomsforest
Copy link
Author

Hello @mushroomsforest - you can fix the failing CI tests by merging master into your branch.

thanks, let me try

@mushroomsforest
Copy link
Author

mushroomsforest commented Jan 8, 2021

@d1ll0n @dharmabrendan
I am not sure why it failed on some file which is not included in my commit.
Please advise if I should fix below issue which seems from OCEAN token or wait for someone to fix it?
Really appreciate

 ● metadata.json › 0x967da4048cD07aB37855c090aAF366e4ce1b9F48 › metadata.json › should only have valid fields

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants