fix: tidy up throwing for dispute status decode

defi-wonderland · Oct 31, 2024 · 12f29ee · 12f29ee
1 parent 85d5c35
commit 12f29ee
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/packages/automated-dispute/src/services/prophetCodec.ts b/packages/automated-dispute/src/services/prophetCodec.ts
@@ -237,18 +237,21 @@ export class ProphetCodec {
      * @returns The DisputeStatus string corresponding to the input value.
      */
     static decodeDisputeStatus(status: number): DisputeStatus {
-        try {
-            const disputeStatus = DISPUTE_STATUS_ENUM[status];
+        let disputeStatus: DisputeStatus | undefined;
 
-            if (!disputeStatus) throw new ProphetDecodingError("dispute.status", toHex(status));
-            else return disputeStatus;
+        try {
+            disputeStatus = DISPUTE_STATUS_ENUM[status];
         } catch (err) {
             throw new ProphetDecodingError(
                 "dispute.status",
                 toHex(status.toString()),
                 err instanceof Error ? err : undefined,
             );
         }
+
+        if (!disputeStatus)
+            throw new ProphetDecodingError("dispute.status", toHex(status.toString()));
+        else return disputeStatus;
     }
 
     /**