feat: implement EboActor.onRequestFinalized handler

[0xyaco]

🤖 Linear

Closes GRT-84

Description

Handle the RequestFinalized event. It simply terminates the EboActor and executes a callback that can be used by the EboProcessor to remove the request from the Map<requestId, EboActor>.

[linear]

GRT-84 Implement onFinalizeRequest

Actors should handle the event RequestFinalized from Prophet's Oracle.

This handler should:

• Terminate the EboActor
  • Clear the registry
  • Call some onTerminate (or similarly named) callback, passed by EboProcessor to unlink the EboActor with its current request id

[0xyaco]

Deleting stuff related to RequestFinalizable, as this case will be handled by the agent's periodic checks; not event related.

[0xnigir1]

just one comment, everything else lgtm 🫡

[0xnigir1]

wdyt about having the callback function as parameter of the onRequestFinalized instead of the constructor?
it will make it obvious that the function will be called from there

[0xyaco]

That's a great proposal, you got me thinking why did I go for this option lol 🤔

=== PR #24 spoiler ahead ===
There are some situations in which that onTerminate callback is being used outside the onRequestFinalized handler (eg the request was "escalated", so the agent stops tracking it as it will be handled by another system outside the EBO agent)

[0xkenj1]

same comment, everything else looks good