-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement EboActor.onDisputeStatusChanged handler #24
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
496fdfa
feat: implement EboActor.onRequestFinalized handler
0xyaco fc1901e
fix: remove DisputeEscalated event
0xyaco e5d52fc
feat: implement EboActor.onDisputeStatusChanged handler
0xyaco 0d9f296
refactor: group imports for exceptions
0xyaco f5e1fb6
Merge remote-tracking branch 'origin/dev' into feat/on-dispute-updated
0xyaco ed6ea51
Merge remote-tracking branch 'origin/dev' into feat/on-dispute-updated
0xyaco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
packages/automated-dispute/src/exceptions/eboRegistry/disputeNotFound.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export class DisputeNotFound extends Error { | ||
constructor(disputeId: string) { | ||
super(`Dispute ${disputeId} was not found.`); | ||
|
||
this.name = "DisputeNotFound"; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export * from "./disputeNotFound.js"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
export * from "./rpcUrlsEmpty.exception.js"; | ||
export * from "./invalidActorState.exception.js"; | ||
export * from "./invalidDisputeStatus.exception.js"; | ||
export * from "./requestMismatch.js"; | ||
export * from "./responseAlreadyProposed.js"; |
7 changes: 7 additions & 0 deletions
7
packages/automated-dispute/src/exceptions/invalidDisputeStatus.exception.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export class InvalidDisputeStatus extends Error { | ||
constructor(disputeId: string, status: string) { | ||
super(`Invalid status ${status} for dispute ${disputeId}`); | ||
|
||
this.name = "InvalidDisputeStatus"; | ||
} | ||
} |
11 changes: 11 additions & 0 deletions
11
packages/automated-dispute/src/exceptions/responseAlreadyProposed.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import { ResponseBody } from "../types/prophet.js"; | ||
|
||
export class ResponseAlreadyProposed extends Error { | ||
constructor(response: ResponseBody) { | ||
super( | ||
`Block ${response.block} was already proposed for epoch ${response.epoch} on chain ${response.chainId}`, | ||
); | ||
|
||
this.name = "ResponseAlreadyProposed"; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add break here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to silently handle those three cases absorbing them and doing nothing; basically we don't need to react immediately to the status being changed; figured that a
case
fallthrough was pretty simplistic here.