feat: on last event #34
Conversation
GRT-153 Implement onNewEvent handler
Actor needs to react to the last known event by executing some RPCs. AC:
|
| return; | ||
| private async onLastEvent(event: EboEvent<EboEventName>) { | ||
| switch (event.name) { | ||
| case "RequestCreated": |
There was a problem hiding this comment.
Do we not need to handle NewEpoch?
There was a problem hiding this comment.
Cool that you've realized that there was this NewEpoch event! Right now we are not going to use it, as the new epoch will be handled by the EboProcessor so let me delete it from the events.
| break; | ||
|
|
||
| default: | ||
| throw new UnknownEvent(event.name); |
There was a problem hiding this comment.
if EboEventName can be something other than the few specified in type EboEventName I'm wondering if we'd need to have a 'string' option in the type and log the event without trying to access event.name 🤔
There was a problem hiding this comment.
A handled event must be one of the listed events.
This is more of an explicitness + maintainability thingy, as we want to force anyone who wants to support a new event to include the new event handler here. Without the default: throw case this would be run silently while there's probably something wrong upstream with the event fetching logic (ie including unsupported events).
🤖 Linear
Closes GRT-153
Description
onNewEventtoonLastEvent(seems more accurate)shouldHandleEventfunction to reflect its actual name lol