feat: add condition to terminate actors #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnigir1
reviewed
Sep 9, 2024
There was a problem hiding this comment.
i think you're not building the command in the EboActor
There was a problem hiding this comment.
Very nice catch! Ended up adding a test to be sure that we're using & running the right command
0xkenj1
reviewed
Sep 9, 2024
| return FinalizeRequest.buildFromEvent( | ||
| event as EboEvent<"RequestFinalized">, | ||
| this.registry, | ||
| ); |
There was a problem hiding this comment.
should we move this entire method to an isolated CommandsFactory?
There was a problem hiding this comment.
There's a TODO comment already, in the docs of this method, for doing that hehe
| @@ -3,12 +3,14 @@ import { NormalizedAddress } from "@ebo-agent/shared"; | |||
| import { Address } from "viem"; | |||
|
|
|||
| export type RequestId = NormalizedAddress; | |||
| export type RequestStatus = "active" | "finalized"; | |||
There was a problem hiding this comment.
Suggested change
| export type RequestStatus = "active" | "finalized"; | |
| export type RequestStatus = "Active" | "Finalized"; |
should we do it this way to have consistent naming convention for statuses?
0xnigir1
approved these changes
Sep 9, 2024
0xkenj1
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-154
Description
Request.statusproperty to indicate the internal state of aRequestEboRegistry