-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: base for agent app #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thoughts on adding a ReadMe/license? or you think the ones in the base repo are enough? Maybe at least adding some instructions on running in the base repo ReadMe would be good
apps/agent/src/index.ts
Outdated
}; | ||
|
||
process.on("unhandledRejection", (reason, p) => { | ||
console.error(`Unhandled Rejection at: \n${inspect(p, undefined, 100)}, \nreason: ${reason}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional that we're logging with console rather than logger?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
{ | ||
"name": "agent", | ||
"version": "1.0.0", | ||
"description": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some other things we could add here would be license: MIT and private: true (though we should add these on our other packages as well to avoid accidental publishing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the private
property, need to ask for The Graph team about licensing.
@jahabeebs totally! Docs, readme, licensing and stuff like that is going to be tackled by the end of the project. But overall, yeah, given the complexity of the project, docs must be super detailed and complete so they are a must. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after addressing @jahabeebs comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left some suggestions (not critical) but i'm not sure if the paths I specified are correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you need a dev
script for running it with hot reload? tsx
is the one we used in chainhub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I'll see how the development goes with this particular app. We'll probably end up needing it during some debugging sessions and such.
"type": "module", | ||
"private": "true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"private": "true", | |
"types": "./dist/index.d.ts", | |
"files": [ | |
"dist/*", | |
"package.json", | |
"!**/*.tsbuildinfo" | |
], | |
"private": "true", |
@@ -4,6 +4,7 @@ | |||
"description": "", | |||
"main": "./dist/index.js", | |||
"type": "module", | |||
"private": "true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"private": "true", | |
"types": "./dist/index.d.ts", | |
"files": [ | |
"dist/*", | |
"package.json", | |
"!**/*.tsbuildinfo" | |
], | |
"private": "true", |
@@ -4,6 +4,7 @@ | |||
"description": "", | |||
"main": "./dist/index.js", | |||
"type": "module", | |||
"private": "true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"private": "true", | |
"types": "./dist/index.d.ts", | |
"files": [ | |
"dist/*", | |
"package.json", | |
"!**/*.tsbuildinfo" | |
], | |
"private": "true", |
🤖 Linear
Closes GRT-167
Description
Set up the basic configuration for the main
agent
app.