feat: check for accounting approval modules #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnigir1
reviewed
Sep 17, 2024
Comment on lines
80
to
82
| const key = (isApproved ? "approved" : "notApproved") as keyof typeof summary; | ||
|
|
||
| summary[key] = { ...summary[key], [moduleName]: moduleAddress }; |
There was a problem hiding this comment.
why is as keyof typeof summary needed? isn't TS intelligent enough to narrow the type?
also doing smth like: summary[key][moduleName] = moduleAddress; seems cleaner to me, do we need to create a new object with the spread operator?
jahabeebs
previously approved these changes
Sep 17, 2024
0xnigir1
previously approved these changes
Sep 17, 2024
0xkenj1
reviewed
Sep 18, 2024
apps/agent/src/index.ts
Outdated
Comment on lines
3
to
4
| import { ProtocolProvider } from "@ebo-agent/automated-dispute/dist/providers/protocolProvider.js"; | ||
| import { AccountingModules } from "@ebo-agent/automated-dispute/dist/types/prophet.js"; |
There was a problem hiding this comment.
dist is pointing to the code that has been built ?
| notApproved: {}, | ||
| }; | ||
|
|
||
| for (const [moduleName, moduleAddress] of Object.entries(this.accountingModules)) { |
There was a problem hiding this comment.
Suggested change
| for (const [moduleName, moduleAddress] of Object.entries(this.accountingModules)) { | |
| for (const key in this.accountingModules) { |
You can do it this way also, just to let you know, not requesting any changes here 🤣
jahabeebs
approved these changes
Sep 19, 2024
| @@ -3,11 +3,22 @@ import { BlockNumberService } from "@ebo-agent/blocknumber"; | |||
| import { Caip2ChainId } from "@ebo-agent/blocknumber/dist/types.js"; | |||
There was a problem hiding this comment.
I know this isn't in your PR but we should clean up these dist imports eventually
There was a problem hiding this comment.
Totally! Already did it in #49 's latest commit
0xnigir1
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-163
Description