test: e2e dispute #72
Conversation
0xyaco
force-pushed
the
test/e2e-scenario-2
branch
from
4a6d0da to
c8b7399
Compare
| * When: | ||
| * - A1 detects RESP1 is wrong | ||
| * | ||
| * Then: |
| * - `EBOFinalityModule.newEpoch(E1, CHAIN1, RESP2.response)` | ||
| * - `OracleRequestFinalized(REQ1.id, RESP2.id, A1.address)` | ||
| */ | ||
| test.skip("dispute response and propose a new one", { timeout: E2E_TEST_TIMEOUT }, async () => { |
There was a problem hiding this comment.
will the test be enabled later?
There was a problem hiding this comment.
Yep, the idea is to enable every test to be run sequentially later
| * @param status - The uint8 value representing the dispute status. | ||
| * @returns The DisputeStatus string corresponding to the input value. | ||
| */ | ||
| private mapDisputeStatus(status: number): DisputeStatus { |
| @@ -343,6 +333,44 @@ export class EboActor { | |||
| await Promise.all(settledDisputes); | |||
| } | |||
|
|
|||
| private getFinalizableResponse(request: Request, atTimestamp: UnixTimestamp) { | |||
| return this.getAcceptedResponse(atTimestamp); | ||
| } | ||
|
|
||
| private async finalizeRequest(request: Request, response: Response) { |
| await this.protocolProvider.finalize(request.prophetData, response.prophetData); | ||
| } catch (err) { | ||
| if (err instanceof CustomContractError) { | ||
| err.setContext({ |
There was a problem hiding this comment.
I noticed in getActiveDisputes you have a this.logger.warn in the catch but not here
There was a problem hiding this comment.
Added a warn here too!
| const events = await this.getEvents(this.lastCheckedBlock, lastBlock.number); | ||
|
|
||
| // Events will sync starting from the block after the last checked one, | ||
| // making the block interval exclusive on its lower bound: |
There was a problem hiding this comment.
exclusive of*
exclusive on means it's included
| responseId: HexUtils.normalize(event.metadata.responseId) as ResponseId, | ||
| responseId: event.metadata.responseId, |
There was a problem hiding this comment.
just double check that normalizing is no longer required
There was a problem hiding this comment.
Nice thing to ask! The main idea of this change is to apply HexUtils.normalize only during functions that fetch events. Starting from that point, the app will always work with already normalized ids.
I've actually grep'd any as (RequestId |ResponseId |DisputeId) to remove any forced casting, keeping only the ones in methods used within ProtocolProvider.getEvent
| const operations = await Promise.allSettled([ | ||
| this.pledgeFor(request, dispute), | ||
| (async () => { | ||
| try { | ||
| const { chainId } = request.decodedData.requestModuleData; | ||
|
|
||
| await this.proposeResponse(chainId); | ||
| } catch (err) { | ||
| if (err instanceof ResponseAlreadyProposed) { | ||
| this.logger.warn(err.message); | ||
| } else { | ||
| this.logger.error( | ||
| `Could not propose a new response after response ${proposedResponse.id} disputal.`, | ||
| ); | ||
|
|
||
| throw err; | ||
| } | ||
| } | ||
| })(), | ||
| ]); | ||
|
|
||
| operations.forEach((element) => { | ||
| if (element.status === "rejected") throw element.reason; | ||
| }); |
There was a problem hiding this comment.
if we're throwing on 'rejected', there's no benefit on doing Promise.allSettled unless we require that Promises are all fulfilled
There was a problem hiding this comment.
random fact: Viem has this stringify implemented
🤖 Linear
Closes GRT-192, GRT-216
Description
Miscelanous fixes:
waitForEventE2E testing util to return the found eventProphetCodecclass