fix: handle decoding errors #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnigir1
reviewed
Oct 31, 2024
| constructor( | ||
| public readonly id: string, | ||
| public readonly data: ByteArray | Hex, | ||
| public readonly err?: Error, |
There was a problem hiding this comment.
although is optional, you're not using err, maybe want to remove it?
There was a problem hiding this comment.
Nice catch! The idea was to log the name of the original error to provide more context during debugging to the user. Ended up logging this err's name too
Comment on lines
240
to
252
| try { | ||
| const disputeStatus = DISPUTE_STATUS_ENUM[status]; | ||
|
|
||
| if (!disputeStatus) throw new ProphetDecodingError("dispute.status", toHex(status)); | ||
| else return disputeStatus; | ||
| } catch (err) { | ||
| throw new ProphetDecodingError( | ||
| "dispute.status", | ||
| toHex(status.toString()), | ||
| err instanceof Error ? err : undefined, | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
is it correct to throw, catch and throw the same error?
| try { | ||
| AddRequest.buildFromEvent(malformedRequestEvent, registry); | ||
|
|
||
| fail("Expecting error"); |
There was a problem hiding this comment.
ooo didn't know this trick
0xyaco
force-pushed
the
fix/handle-decode-errors
branch
from
f7d5e47 to
6431356
Compare
jahabeebs
previously approved these changes
Oct 31, 2024
0xnigir1
reviewed
Oct 31, 2024
Comment on lines
242
to
250
| try { | ||
| disputeStatus = DISPUTE_STATUS_ENUM[status]; | ||
| } catch (err) { | ||
| throw new ProphetDecodingError( | ||
| "dispute.status", | ||
| toHex(status.toString()), | ||
| err instanceof Error ? err : undefined, | ||
| ); | ||
| } |
There was a problem hiding this comment.
Suggested change
| try { | |
| disputeStatus = DISPUTE_STATUS_ENUM[status]; | |
| } catch (err) { | |
| throw new ProphetDecodingError( | |
| "dispute.status", | |
| toHex(status.toString()), | |
| err instanceof Error ? err : undefined, | |
| ); | |
| } | |
| disputeStatus = DISPUTE_STATUS_ENUM[status]; |
try/catch is not needed anymore right?
0xnigir1
approved these changes
Oct 31, 2024
jahabeebs
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-242
Description
bytesproperties read from Prophet eventsProphetCodec.decode...calls from ProtocolProvidergetXXXEventto use them during actual event processing and not event fetching