feat: update RPC abis and behavior #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dress-to-config' into feat/grt-230-update-rpc-abis-and-behavior
…eat/grt-230-update-rpc-abis-and-behavior
…-behavior' into feat/grt-230-update-rpc-abis-and-behavior
0xyaco
previously approved these changes
Nov 22, 2024
| * @throws Will throw an error if the chains array is empty or if the transaction fails. | ||
| * @returns A promise that resolves when the request is successfully created. | ||
| */ | ||
| createRequest(epoch: bigint, chains: Caip2ChainId): Promise<void>; |
There was a problem hiding this comment.
oops this was when I was using some old abi and refactoring 😅
There was a problem hiding this comment.
removed this change from the protocolProvider itself too
| @@ -152,13 +153,13 @@ export class ProtocolProvider implements IProtocolProvider { | |||
| address: contracts.oracle, | |||
| abi: oracleAbi, | |||
| client: this.l2WriteClient, | |||
| }); | |||
| }) as GetContractReturnType<typeof oracleAbi, typeof this.l2WriteClient, Address>; | |||
There was a problem hiding this comment.
Do we need this as for these contracts?
| private getDefaultAccessControl(): AccessControl { | ||
| return { | ||
| user: this.protocolProvider.getAccountAddress(), | ||
| data: "0x", |
There was a problem hiding this comment.
The 0x is excellent, no need to add anything else to the data field
0xnigir1
previously approved these changes
Nov 22, 2024
Base automatically changed from
feat/grt-229-add-service-prov-address-to-config
to
dev
November 22, 2024 14:01
jahabeebs
dismissed stale reviews from 0xnigir1 and 0xyaco
The base branch was changed.
0xyaco
approved these changes
Nov 22, 2024
0xnigir1
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-230
Description