feat: EBOFinalityModule

src/contracts/EBOFinalityModule.sol

@@ -10,7 +10,7 @@ import {IEBOFinalityModule} from 'interfaces/IEBOFinalityModule.sol';
 
 /**
  * @title EBOFinalityModule
- * @notice Module allowing users to call a function on a contract
+ * @notice Module allowing users to index data into the subgraph
  * as a result of a request being finalized
  */
 contract EBOFinalityModule is Module, IEBOFinalityModule {
@@ -39,21 +39,12 @@ contract EBOFinalityModule is Module, IEBOFinalityModule {
     _moduleName = 'EBOFinalityModule';
   }
 
-  /// @inheritdoc IEBOFinalityModule
-  function decodeRequestData(bytes calldata _data) public pure returns (RequestParameters memory _params) {
-    _params = abi.decode(_data, (RequestParameters));
-  }
-
   /// @inheritdoc IEBOFinalityModule
   function finalizeRequest(
     IOracle.Request calldata _request,
     IOracle.Response calldata _response,
     address _finalizer
   ) external override(Module, IEBOFinalityModule) onlyOracle {
-    RequestParameters memory _params = decodeRequestData(_request.finalityModuleData);
-
-    _params.target.call(_params.data);
-    emit Callback(_response.requestId, _params.target, _params.data);
     emit RequestFinalized(_response.requestId, _response, _finalizer);
     // emit NewEpoch(_response.epoch, _response.chainId, _response.block);
   }
@@ -71,28 +62,4 @@ contract EBOFinalityModule is Module, IEBOFinalityModule {
       emit AmendEpoch(_epoch, _chainIds[i], _blockNumbers[i]);
     }
   }
-
-  /// @inheritdoc IModule
-  function validateParameters(bytes calldata _encodedParameters)
-    external
-    view
-    override(Module, IModule)
-    returns (bool _valid)
-  {
-    RequestParameters memory _params = decodeRequestData(_encodedParameters);
-    _valid = _targetHasBytecode(_params.target) && _params.data.length != 0;
-  }
-
-  /**
-   * @notice Checks if a target address has bytecode
-   * @param _target The address to check
-   * @return _hasBytecode Whether the target has bytecode or not
-   */
-  function _targetHasBytecode(address _target) private view returns (bool _hasBytecode) {
-    uint256 _size;
-    assembly {
-      _size := extcodesize(_target)
-    }
-    _hasBytecode = _size > 0;
-  }
 }

src/interfaces/IEBOFinalityModule.sol

@@ -7,22 +7,14 @@ import {IFinalityModule} from
 
 /**
  * @title EBOFinalityModule
- * @notice Module allowing users to call a function on a contract
+ * @notice Module allowing users to index data into the subgraph
  * as a result of a request being finalized
  */
 interface IEBOFinalityModule is IFinalityModule {
   /*///////////////////////////////////////////////////////////////
                               EVENTS
   //////////////////////////////////////////////////////////////*/
 
-  /**
-   * @notice A callback has been executed
-   * @param _requestId The id of the request being finalized
-   * @param _target The target address for the callback
-   * @param _data The calldata forwarded to the target
-   */
-  event Callback(bytes32 indexed _requestId, address indexed _target, bytes _data);
-
   /**
    * @notice Emitted when the block number has been resolved for a particular epoch-chainId pair
    * @param _epoch The new epoch
@@ -53,20 +45,6 @@ interface IEBOFinalityModule is IFinalityModule {
    */
   error EBOFinalityModule_LengthMismatch();
 
-  /*///////////////////////////////////////////////////////////////
-                              STRUCTS
-  //////////////////////////////////////////////////////////////*/
-
-  /**
-   * @notice Parameters of the request as stored in the module
-   * @param target The target address for the callback
-   * @param data The calldata forwarded to the target
-   */
-  struct RequestParameters {
-    address target;
-    bytes data;
-  }
-
   /*///////////////////////////////////////////////////////////////
                               LOGIC
   //////////////////////////////////////////////////////////////*/
@@ -78,15 +56,7 @@ interface IEBOFinalityModule is IFinalityModule {
   function ARBITRATOR() external view returns (address _arbitrator);
 
   /**
-   * @notice Returns the decoded data for a request
-   * @param _data The encoded request parameters
-   * @return _params The struct containing the parameters for the request
-   */
-  function decodeRequestData(bytes calldata _data) external view returns (RequestParameters memory _params);
-
-  /**
-   * @notice Finalizes the request by executing the callback call on the target
-   * @dev The success of the callback call is purposely not checked
+   * @notice Finalizes the request by publishing the response
    * @param _request The request being finalized
    * @param _response The final response
    * @param _finalizer The address that initiated the finalization