fix: don't return undefined on error

defi-wonderland · Sep 3, 2024 · 13c9021 · 13c9021
1 parent 32b37b1
commit 13c9021
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 25 deletions.
diff --git a/packages/metrics/src/l2/l2Metrics.service.ts b/packages/metrics/src/l2/l2Metrics.service.ts
@@ -1,6 +1,3 @@
-import { isNativeError } from "util/types";
-import { BaseError } from "viem";
-
 import { ZKChainProvider } from "@zkchainhub/chain-providers";
 import { ILogger } from "@zkchainhub/shared";
 
@@ -47,16 +44,7 @@ export class L2MetricsService {
      * @returns A Promise that resolves to the number of the last verified block, or undefined if an error occurs.
      */
     async getLastVerifiedBlock(lastVerifiedBatch: number): Promise<number | undefined> {
-        try {
-            const [, endBlock] = await this.provider.getL1BatchBlockRange(lastVerifiedBatch);
-            return endBlock;
-        } catch (error) {
-            if (error instanceof BaseError) {
-                this.logger.error(error.message);
-            } else if (isNativeError(error)) {
-                this.logger.error(error);
-            }
-            return undefined;
-        }
+        const [, endBlock] = await this.provider.getL1BatchBlockRange(lastVerifiedBatch);
+        return endBlock;
     }
 }
diff --git a/packages/metrics/test/unit/l2/l2Metrics.service.spec.ts b/packages/metrics/test/unit/l2/l2Metrics.service.spec.ts
@@ -1,4 +1,3 @@
-import { BaseError } from "viem";
 import { beforeEach, describe, expect, it, vi } from "vitest";
 
 import { ZKChainProvider } from "@zkchainhub/chain-providers";
@@ -78,15 +77,5 @@ describe("L2MetricsService", () => {
             expect(result).toBe(expectedEndBlock);
             expect(provider.getL1BatchBlockRange).toHaveBeenCalledWith(lastVerifiedBatch);
         });
-        it("return undefined if an error occurs", async () => {
-            const lastVerifiedBatch = 500;
-            vi.spyOn(provider, "getL1BatchBlockRange").mockRejectedValue(
-                new BaseError("Invalid batch number"),
-            );
-
-            const result = await service.getLastVerifiedBlock(lastVerifiedBatch);
-
-            expect(result).toBeUndefined();
-        });
     });
 });