feat: init nest monorepo, delete old turborepo config & use pnpm #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZKS-84 Init monorepo
Use NestJS CLI to init a new monorepo, consider previous zkchainhub repo config |
0xkenj1
requested changes
Jul 9, 2024
.vscode/settings.json
Outdated
There was a problem hiding this comment.
Not sure if we need this file, if we don’t lets remove it
There was a problem hiding this comment.
we need it so we all have the same 'formatOnSave' configuration for vscode and share the same extension for ESLint
README.md
Outdated
| @@ -4,59 +4,40 @@ | |||
|
|
|||
| The zkChainHub project for zkSync involves the creation of a comprehensive data management system. This project is designed to provide key insights into the zkSync network, making it an invaluable tool for users and developers. | |||
There was a problem hiding this comment.
We should add a better description for the project, probably the tech design doc would provide some help
README.md
Outdated
| ``` | ||
| ```bash | ||
| $ nest g library my-library | ||
| ``` |
There was a problem hiding this comment.
Lets also add “Creating a new app”
lint-staged.config.js
Outdated
There was a problem hiding this comment.
Lets see if we can replace this with some line in package.json , to avoid adding a file with just one line
0xkenj1
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes ZKS-84 ZKS-90
Description
Scaffold the base monorepo using Nest CLI using pnpm. Deletes previous structure from turborepo.
New structure is:
Note: didn't delete packages folder so later we have it there to refactor into a library but is not part of new src code