feat: viem wrapper with readContract and base methods #25
Conversation
ZKS-94 EVM Provider - Base
Base should include a
Also add non-contract related function, for example: |
There was a problem hiding this comment.
IEvmProvider interface is not needed imo, given that we are not going to have many implementations of EvmProvider
There was a problem hiding this comment.
Also notice that readContract() has a very specific signature coupled to viem types. Probably a better approach for interfaces, in case are needed, would be segregation, having 2 different interfaces for example, IEvmProvider and IContractReader
| * Acts as a wrapper around Viem library to provide methods to interact with an EVM-based blockchain. | ||
| */ | ||
| @Injectable() | ||
| export class ViemProviderService implements IEvmProvider { |
There was a problem hiding this comment.
I would rename this ViemProviderService to EvmProviderService
| /** | ||
| * Retrieves the value from a storage slot at a given address. | ||
| * @param {Address} address The address of the contract. | ||
| * @param {number} slot The slot number to read. | ||
| * @returns {Promise<Hex>} A Promise that resolves to the value of the storage slot. | ||
| * @throws {InvalidArgumentException} If the slot is not a positive integer. | ||
| */ |
There was a problem hiding this comment.
Just a suggestion here. When you are implementing an interface i think you can inherit the natspec from it.
| http: jest.fn(), | ||
| })); | ||
|
|
||
| describe("ViemProviderService", () => { |
| providers: [EvmProviderService, ViemProviderService], | ||
| exports: [EvmProviderService, ViemProviderService], |
There was a problem hiding this comment.
we can get rid of EvmProviderService. Here should be just 1 providers item and 1 exports item
🤖 Linear
Closes ZKS-67 ZKS-94 ZKS-93
Description
Create a Viem library wrapper service with base methods functionality:
getBalancegetBlockNumbergetGasPricegetStorageAtreadContractreadContractallows to perform an eth_call for view/pure functions in a type-safe way by providing the contract ABI