feat: scaffold pricing module lib #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xyaco
previously approved these changes
Jul 24, 2024
0xkenj1
requested changes
Jul 24, 2024
There was a problem hiding this comment.
We need to add an interface that will be used by the consumers of this module. The CoingeckoService should implement this interface. It could be named IPricingService, for example. This will ensure that the pricing service is easily replaceable with any provider in the future.
0xkenj1
reviewed
Jul 29, 2024
|
|
||
| @Injectable() | ||
| export class CoingeckoService implements IPricingService { | ||
| private readonly API_BASE_URL = "https://api.coingecko.com/api/v3/"; |
There was a problem hiding this comment.
Wdyt if we remove this hardcoded value and ask for 2 parameters baseUrl and apiKey instead???
There was a problem hiding this comment.
okayy sound good to me
|
I'll setup the ConfigService in a different PR according to what we discussed in DM, injecting ConfigService instead of raw value |
0xkenj1
approved these changes
Jul 29, 2024
0xyaco
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes ZKS-63
Description
Scaffold Pricing module library:
CoingeckoService