feat: chain type #42
Merged
feat: chain type #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZKS-79 Chain type
Use AC:
|
0xnigir1
reviewed
Aug 8, 2024
| "getPubdataPricingMode", | ||
| [], | ||
| ); | ||
| }); |
There was a problem hiding this comment.
we should add the test case for Validium (if 1 is returned)
There was a problem hiding this comment.
lets do it ser, will add it
0xnigir1
previously approved these changes
Aug 8, 2024
0xyaco
previously approved these changes
Aug 8, 2024
0xkenj1
dismissed stale reviews from 0xyaco and 0xnigir1
The merge-base changed after approval.
0xnigir1
approved these changes
Aug 8, 2024
0xyaco
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes ZKS-79
Description
chainTypelogic toL1MetricsServicefetchDiamondProxyAddress