feat: ui integration #48
Conversation
…o feat/ui-integration
…o feat/ui-integration
|
ZKS-165 Implement interceptor to serialize `bigint` as `string` ZKS-170 Add a zkchains registry ZKS-162 Rename gasInfo interface
Currently we have: Suggested : |
| /** | ||
| * RPC class representing the RPC information. | ||
| */ | ||
| export class RPC { | ||
| /** | ||
| * The URL of the RPC. | ||
| * @type {string} | ||
| * @memberof RPC | ||
| */ | ||
| url: string; | ||
|
|
||
| /** | ||
| * The status of the RPC (optional). | ||
| * @type {boolean} | ||
| * @memberof RPC | ||
| */ | ||
| status?: boolean; | ||
|
|
||
| constructor(data: RPC) { | ||
| this.url = data.url; | ||
| this.status = data.status; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this fine to delete? Not being used, right?
There was a problem hiding this comment.
not being used, is just string[]
There was a problem hiding this comment.
we could just delete this file right wdyt?
There was a problem hiding this comment.
lets keep it, since it has the e2e testing setup :)
| @@ -13,30 +14,26 @@ export class ZKChainInfo { | |||
| * @type {ChainType} | |||
| * @memberof ZKChainInfo | |||
| */ | |||
| @ApiProperty({ enum: Chains, enumName: "ChainType" }) | |||
There was a problem hiding this comment.
aren't we going to leave field response example for the swagger?
There was a problem hiding this comment.
i want to review swagger examples on a different pr sir
| }); | ||
| } | ||
| const { chainId: _metadataChainId, ...metadataRest } = metadata; | ||
| void _metadataChainId; |
There was a problem hiding this comment.
we can delete this line and add the eslint rule to not flag the unused var on rest params:
.eslintrc.js
"@typescript-eslint/no-unused-vars": [
"error",
{ argsIgnorePattern: "_+", ignoreRestSiblings: true },
],
There was a problem hiding this comment.
have you tried this ? is it working, i don't see any issues with void. Actually i think is better to understand what is happening
There was a problem hiding this comment.
yep it works, i have to say i've never seen this void trick jajaj
## Description Update README --------- Co-authored-by: 0xkenj1 <[email protected]>
🤖 Linear
Closes ZKS-165 ZKS-170 ZKS-162 ZKS-168
Description