feat: responsiveness #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xArdy
reviewed
Aug 12, 2024
src/components/TitleBanner.tsx
Outdated
Comment on lines
30
to
36
| display: isMobile ? 'grid' : 'flex', | ||
| gridTemplateColumns: isMobile ? 'auto 1fr' : 'none', | ||
| alignItems: 'center', | ||
| alignSelf: 'flex-start', | ||
| gap: currentTheme.gap, | ||
| justifyContent: isMobile ? 'start' : 'center', | ||
| textAlign: isMobile ? 'left' : 'center', |
There was a problem hiding this comment.
I think adding mediaQueries would be better. wdyt?
src/components/TitleBanner.tsx
Outdated
| fontWeight: 700, | ||
| lineHeight: '4rem', | ||
| letterSpacing: '-0.03em', | ||
| gridColumn: isMobile ? 'span 2' : 'auto', |
Comment on lines
119
to
123
| display: isMobile ? 'grid' : 'flex', | ||
| alignItems: 'center', | ||
| justifyContent: isMobile ? 'space-between' : 'flex-start', | ||
| gap: currentTheme.gap, | ||
| gridTemplateColumns: isMobile ? 'repeat(2, 1fr)' : 'none', |
src/containers/Header/index.tsx
Outdated
Comment on lines
54
to
69
| return isMobile ? ( | ||
| <MobileHeader | ||
| theme={theme} | ||
| goToHome={goToHome} | ||
| handleChangeLanguage={handleChangeLanguage} | ||
| localesMap={localesMap} | ||
| changeTheme={changeTheme} | ||
| /> | ||
| ) : ( | ||
| <DesktopHeader | ||
| theme={theme} | ||
| goToHome={goToHome} | ||
| handleChangeLanguage={handleChangeLanguage} | ||
| localesMap={localesMap} | ||
| changeTheme={changeTheme} | ||
| /> |
There was a problem hiding this comment.
I would recommend using a binary conditional (&&)
src/containers/Landing/index.tsx
Outdated
| return { | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| padding: isMobile ? '0 1rem' : '0 7rem', |
0xArdy
approved these changes
Aug 12, 2024
Comment on lines
11
to
+14
| export const TotalValueLocked = ({ tvl }: TotalValueLockedProps) => { | ||
| const theme = useTheme(); | ||
| const isMobile = useMediaQuery(theme.breakpoints.down('sm')); | ||
|
|
There was a problem hiding this comment.
would be nice if we can split these components into different files in another pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.